bbende commented on code in PR #7092:
URL: https://github.com/apache/nifi/pull/7092#discussion_r1157368613
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/BucketFlowResource.java:
##########
@@ -295,6 +295,48 @@ public Response createFlowVersion(
return
Response.status(Response.Status.OK).entity(createdSnapshot).build();
}
+ @POST
+ @Path("{flowId}/versions/migrate")
Review Comment:
We had discussed this offline and landed on the `/migrate` approach to
clearly separate the usage of the API. The idea was that no one should really
be calling the `/migrate` end-point, except for a specific utility that wants
to move data between two registries.
However, I agree that it generally does not follow REST standards, so I'm
not that opposed to using a query parameter on the existing end-points. If we
were to go with a query parameter then it should probably be
`preserveSourceProperties` because it is more general than just the `author`.
We have 3 different entities that would be migrated:
- `Buckets` - need to preserve id, rather than generating new
- `Flows` - need to preserve id, rather than generating new
- `Flow Versions` - need to preserve id and author, rather than generating
new and using authenticated user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
