szaszm commented on code in PR #1554:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1163989146


##########
extensions/aws/CMakeLists.txt:
##########


Review Comment:
   In this case, we should only do the wholearchive linking on the platforms 
where it's necessary. It generates bloated binaries, and there's no need to do 
so on x86 if it used to work without this flag there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to