[
https://issues.apache.org/jira/browse/NIFI-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690800#comment-15690800
]
ASF GitHub Bot commented on NIFI-3092:
--------------------------------------
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1268
NIFI-3092 - Double quoting java invocation in bat files with %*
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] - N/A - Have you written or updated unit tests to verify your changes?
- [x] - N/A - If adding new dependencies to the code, are these
dependencies licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] - N/A - If applicable, have you updated the LICENSE file, including
the main LICENSE file under nifi-assembly?
- [x] - N/A - If applicable, have you updated the NOTICE file, including
the main NOTICE file found under nifi-assembly?
- [x] - N/A - If adding new Properties, have you added .displayName in
addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] - N/A - Have you ensured that format looks appropriate for the output
in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3092
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1268
----
commit 060e5196847b33680ba90377861c27e126f627a9
Author: Bryan Rosander <[email protected]>
Date: 2016-11-23T17:05:27Z
NIFI-3092 - Double quoting java invocation in bat files with %*
----
> NiFi Toolkit bat files should quote command line args properly
> --------------------------------------------------------------
>
> Key: NIFI-3092
> URL: https://issues.apache.org/jira/browse/NIFI-3092
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Bryan Rosander
> Assignee: Bryan Rosander
>
> The toolkit bat files currently don't quote the command line arguments passed
> to them. This results in problems with spaces or special characters as
> arguments.
> We should be able to address this by double-quoting the cmd arguments. If we
> add a space before the closing "", we should be able to handle whether or not
> the last argument is quoted.
> E.g. without spaces -n "localhost(2)" would be rendered as -n
> "localhost(2)""" which breaks but with space it will be -n "localhost(2)" ""
> which is interpreted correctly.
> See
> http://stackoverflow.com/questions/12891383/correct-quoting-for-cmd-exe-for-multiple-arguments#answer-12892791
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
