timeabarna commented on code in PR #7092: URL: https://github.com/apache/nifi/pull/7092#discussion_r1171178295
########## nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/result/registry/VersionedFlowSnapshotsResult.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.toolkit.cli.impl.result.registry; + +import org.apache.commons.lang3.Validate; +import org.apache.nifi.registry.flow.VersionedFlowSnapshot; +import org.apache.nifi.toolkit.cli.api.WritableResult; +import org.apache.nifi.toolkit.cli.impl.util.JacksonUtils; + +import java.io.IOException; +import java.io.OutputStream; +import java.io.PrintStream; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.Iterator; + +/** + * Result for a list of VersionedFlowSnapshots. + * + * If this result was created with a non-null exportDirectoryName, then the write method will ignore + * the passed in PrintStream, and will write the serialized snapshot to the given directory. + * The file name will be generated from the flow name and its version. + * + * If this result was created with a null exportDirectoryName, then the write method will write the + * serialized snapshots to the given PrintStream. + */ +public class VersionedFlowSnapshotsResult implements WritableResult<Iterator<VersionedFlowSnapshot>> { + private static final String FILE_NAME_PREFIX = "toolkit_registry_export_all"; + private static final String EXPORT_FILE_NAME = "%s/%s_%s_%s_%d"; + private static final String SEPARATOR = "_"; + private static final String REPLACEMENT = "-"; + private final Iterator<VersionedFlowSnapshot> versionedFlowSnapshots; + private final String exportDirectoryName; + + public VersionedFlowSnapshotsResult(final Iterator<VersionedFlowSnapshot> versionedFlowSnapshots, final String exportDirectoryName) { + this.versionedFlowSnapshots = versionedFlowSnapshots; + this.exportDirectoryName = exportDirectoryName; + Validate.notNull(this.versionedFlowSnapshots); + } + + @Override + public Iterator<VersionedFlowSnapshot> getResult() { + return versionedFlowSnapshots; + } + + @Override + public void write(final PrintStream output) throws IOException { + while (versionedFlowSnapshots.hasNext()) { + final VersionedFlowSnapshot versionedFlowSnapshot = versionedFlowSnapshots.next(); + if (exportDirectoryName != null) { + final String bucketName = versionedFlowSnapshot.getBucket().getName().replaceAll(SEPARATOR, REPLACEMENT); + final String flowName = versionedFlowSnapshot.getFlow().getName().replaceAll(SEPARATOR, REPLACEMENT); + final int version = versionedFlowSnapshot.getSnapshotMetadata().getVersion(); + final String exportFileName = String.format(EXPORT_FILE_NAME, exportDirectoryName, FILE_NAME_PREFIX, bucketName, flowName, version); + try (final OutputStream resultOut = Files.newOutputStream(Paths.get(exportFileName))) { + JacksonUtils.write(versionedFlowSnapshot, resultOut); + } Review Comment: The stackstrace is strange as it does not mention Paths.get which probably causing this exception. I've added catch and also updated the documentation that the directory must exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
