martinzink commented on code in PR #1558: URL: https://github.com/apache/nifi-minifi-cpp/pull/1558#discussion_r1172455456
########## docker/rockylinux/Dockerfile: ########## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +FROM rockylinux:8 +LABEL maintainer="Apache NiFi <d...@nifi.apache.org>" + +ARG MINIFI_VERSION +ARG UID=1000 +ARG GID=1000 + +# MINIFI_OPTIONS will be passed directly to cmake +# use it to define cmake options (e.g. -DENABLE_AWS=ON -DENABLE_AZURE=ON) +ARG MINIFI_OPTIONS="" +ARG CMAKE_BUILD_TYPE=Release +ARG DOCKER_SKIP_TESTS=ON +ARG DOCKER_MAKE_TARGET="all" + +ENV MINIFI_BASE_DIR /opt/minifi +ENV MINIFI_HOME $MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION +ENV USER minificpp + +RUN mkdir -p $MINIFI_BASE_DIR +COPY . ${MINIFI_BASE_DIR} + +# Install the system dependencies needed for a build +# gpsd-devel and ccache are in EPEL +RUN dnf -y install epel-release && dnf -y install sudo git which make libarchive ccache ca-certificates cmake && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_GPS=ON"; then dnf -y install gpsd-devel; fi && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_JNI=ON"; then dnf -y install java-1.8.0-openjdk maven; fi && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PCAP=ON"; then dnf -y install libpcap-devel; fi && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_USB_CAMERA=ON"; then dnf -y install libpng-devel libusbx-devel; fi && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_OPENCV=ON" || echo "$MINIFI_OPTIONS" | grep -q "ENABLE_BUSTACHE=ON"; then dnf -y install boost-devel; fi && \ + if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_LUA_SCRIPTING=ON"; then dnf --enablerepo=powertools install lua-devel; fi && \ Review Comment: sry I might have left out the noprompt flag from my earlier suggestion ```suggestion if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_LUA_SCRIPTING=ON"; then dnf -y --enablerepo=powertools install lua-devel; fi && \ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
