MikeThomsen commented on code in PR #7197:
URL: https://github.com/apache/nifi/pull/7197#discussion_r1181136943
##########
nifi-registry/nifi-registry-docker-maven/dockermaven/pom.xml:
##########
@@ -61,6 +61,22 @@
<goal>run</goal>
</goals>
</execution>
+ <execution>
+ <id>copy-toolkit-for-docker</id>
+ <phase>process-sources</phase>
+ <configuration>
+ <target name="copy toolkit assembly to
nifi-registry-docker for image build">
Review Comment:
I think it would better to use the approach used in the main docker image
where the NiFi binary is downloaded rather than pulled from the nifi-assembly
package.
https://github.com/apache/nifi/blob/3d60e4a4f602b88686806ee84d1da816c9c398a2/nifi-docker/dockerhub/Dockerfile#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
