mattyb149 commented on code in PR #7212:
URL: https://github.com/apache/nifi/pull/7212#discussion_r1181328076
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java:
##########
@@ -159,6 +159,7 @@ public List<PropertyDescriptor>
getSupportedPropertyDescriptors() {
@Override
protected Collection<ValidationResult> customValidate(final
ValidationContext validationContext) {
List<ValidationResult> problems = new ArrayList<>();
+ problems.addAll(super.customValidate(validationContext));
Review Comment:
Was this an oversight earlier, to not call the super version?
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java:
##########
@@ -373,6 +374,11 @@ protected Collection<ValidationResult>
customValidate(ValidationContext context)
boolean clientIsSet = context.getProperty(CLIENT_SERVICE).isSet();
boolean uriIsSet = context.getProperty(URI).isSet();
+ if (uriIsSet) {
+
DeprecationLoggerFactory.getLogger(AbstractMongoProcessor.class).warn("The
MongoDB URI and other client " +
+ "configuration properties on this proessor are deprecated
and will be removed in NiFi 2.0");
Review Comment:
Minor typo on `processor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
