[
https://issues.apache.org/jira/browse/NIFI-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696901#comment-15696901
]
ASF GitHub Bot commented on NIFI-3104:
--------------------------------------
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1273
NIFI-3104 Remove MPL-licensed test data from TestExtractHL7Attributes
This PR removes the offending tests and updates relevant NOTICE files to
remove, now irrelevant, notices.
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-3104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
----
commit a60c2197f96ac2182d0b5a5809deab19be5f9251
Author: Joey Frazee <[email protected]>
Date: 2016-11-25T23:39:09Z
Removed tests derived from HAPI test data
----
> Remove MPL-licensed test data from TestExtractHL7Attributes
> -----------------------------------------------------------
>
> Key: NIFI-3104
> URL: https://issues.apache.org/jira/browse/NIFI-3104
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0
> Reporter: Joey Frazee
> Assignee: Joey Frazee
> Fix For: 1.1.0
>
>
> NIFI-2887 added test data to the ExtractHL7Attributes tests from the HAPI
> project that is MPL (category B) licensed. While MPL code is ok for binary
> dependencies it can't be included in source, so these tests need to be
> removed and replaced with non-derivative HL7 examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
