[ 
https://issues.apache.org/jira/browse/MINIFICPP-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated MINIFICPP-2116:
------------------------------------
    Description: 
1. update RocksDB to 8.0.0+ (latest: 8.1.1) 
https://github.com/facebook/rocksdb/pull/11118
2. Fix libminifi errors ( Annotation.h lacks <cstdint> )
3. update abseil: 
https://github.com/abseil/abseil-cpp/commit/b957f0ccd00481cd4fd663d8320aa02ae0564f18
4. update opencv to 4.7.0: 
https://github.com/opencv/opencv/commit/03130548eaa89e5491f669bf96af324890a26374
 https://github.com/opencv/ade/commit/7cecc9138b89e1946e3e515727bb69b2ab119806

1.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.cc:9:
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:65:7:
 error: ‘uint8_t’ does not name a type
   65 | const uint8_t kNoEntry = 255;
      |       ^~~~~~~
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:1:1:
 note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include 
<cstdint>’?
  +++ |+#include <cstdint>
    1 | // Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
{noformat}


2.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/libminifi/include/agent/agent_docs.h:24,
                 from 
/home/szaszm/nifi-minifi-cpp/libminifi/src/agent/agent_docs.cpp:18:
/home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:6: warning: 
elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword
   30 | enum class Input : uint8_t {
      | ~~~~ ^~~~~
      |      -----
/home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:18: error: 
found ‘:’ in nested-name-specifier, expected ‘::’
   30 | enum class Input : uint8_t {
      |                  ^
      |                  ::
{noformat}


3.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.cc:16:
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:6:
 warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ 
keyword
   34 | enum class FormatConversionChar : uint8_t;
      | ~~~~ ^~~~~
      |      -----
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:33:
 error: found ‘:’ in nested-name-specifier, expected ‘::’
   34 | enum class FormatConversionChar : uint8_t;
      |                                 ^
      |                                 ::
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:12:
 error: ‘FormatConversionChar’ has not been declared
   34 | enum class FormatConversionChar : uint8_t;
      |            ^~~~~~~~~~~~~~~~~~~~
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:35:6:
 warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ 
keyword
   35 | enum class FormatConversionCharSet : uint64_t;
      | ~~~~ ^~~~~
      |      -----
{noformat}

4.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/passes/topological_sort.hpp:17,
                 from 
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/source/topological_sort.cpp:7:
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:101:10:
 error: ‘uintptr_t’ in namespace ‘std’ does not name a type
  101 |     std::uintptr_t m_srcGraph;
      |          ^~~~~~~~~
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:22:1:
 note: ‘std::uintptr_t’ is defined in header ‘<cstdint>’; did you forget to 
‘#include <cstdint>’?
   21 | #include "typed_metadata.hpp"
  +++ |+#include <cstdint>
   22 |
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:
 In member function ‘const ade::Graph& ade::ConstTypedGraph<Types>::getCGraph() 
const’:
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:106:53:
 error: ‘m_srcGraph’ was not declared in this scope
  106 |         return *reinterpret_cast<const ade::Graph*>(m_srcGraph);
      |                                                     ^~~~~~~~~~
{noformat}

workaround: 
{code:sh}
export CXXFLAGS="-include cstdint"
{code}


  was:
1. update RocksDB to 8.0.0+ (latest: 8.1.1) 
https://github.com/facebook/rocksdb/pull/11118
2. Fix libminifi errors ( Annotation.h lacks <cstdint> )
3. update abseil: 
https://github.com/abseil/abseil-cpp/commit/b957f0ccd00481cd4fd663d8320aa02ae0564f18
4. update opencv to 4.7.0: 
https://github.com/opencv/opencv/commit/03130548eaa89e5491f669bf96af324890a26374
 https://github.com/opencv/ade/commit/7cecc9138b89e1946e3e515727bb69b2ab119806

1.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.cc:9:
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:65:7:
 error: ‘uint8_t’ does not name a type
   65 | const uint8_t kNoEntry = 255;
      |       ^~~~~~~
/home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:1:1:
 note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include 
<cstdint>’?
  +++ |+#include <cstdint>
    1 | // Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
{noformat}


2.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/libminifi/include/agent/agent_docs.h:24,
                 from 
/home/szaszm/nifi-minifi-cpp/libminifi/src/agent/agent_docs.cpp:18:
/home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:6: warning: 
elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword
   30 | enum class Input : uint8_t {
      | ~~~~ ^~~~~
      |      -----
/home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:18: error: 
found ‘:’ in nested-name-specifier, expected ‘::’
   30 | enum class Input : uint8_t {
      |                  ^
      |                  ::
{noformat}

3.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.cc:16:
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:6:
 warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ 
keyword
   34 | enum class FormatConversionChar : uint8_t;
      | ~~~~ ^~~~~
      |      -----
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:33:
 error: found ‘:’ in nested-name-specifier, expected ‘::’
   34 | enum class FormatConversionChar : uint8_t;
      |                                 ^
      |                                 ::
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:12:
 error: ‘FormatConversionChar’ has not been declared
   34 | enum class FormatConversionChar : uint8_t;
      |            ^~~~~~~~~~~~~~~~~~~~
/home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:35:6:
 warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ 
keyword
   35 | enum class FormatConversionCharSet : uint64_t;
      | ~~~~ ^~~~~
      |      -----
{noformat}

4.
{noformat}
In file included from 
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/passes/topological_sort.hpp:17,
                 from 
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/source/topological_sort.cpp:7:
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:101:10:
 error: ‘uintptr_t’ in namespace ‘std’ does not name a type
  101 |     std::uintptr_t m_srcGraph;
      |          ^~~~~~~~~
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:22:1:
 note: ‘std::uintptr_t’ is defined in header ‘<cstdint>’; did you forget to 
‘#include <cstdint>’?
   21 | #include "typed_metadata.hpp"
  +++ |+#include <cstdint>
   22 |
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:
 In member function ‘const ade::Graph& ade::ConstTypedGraph<Types>::getCGraph() 
const’:
/home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:106:53:
 error: ‘m_srcGraph’ was not declared in this scope
  106 |         return *reinterpret_cast<const ade::Graph*>(m_srcGraph);
      |                                                     ^~~~~~~~~~
{noformat}



> Fix GCC 13 build
> ----------------
>
>                 Key: MINIFICPP-2116
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-2116
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Marton Szasz
>            Priority: Major
>
> 1. update RocksDB to 8.0.0+ (latest: 8.1.1) 
> https://github.com/facebook/rocksdb/pull/11118
> 2. Fix libminifi errors ( Annotation.h lacks <cstdint> )
> 3. update abseil: 
> https://github.com/abseil/abseil-cpp/commit/b957f0ccd00481cd4fd663d8320aa02ae0564f18
> 4. update opencv to 4.7.0: 
> https://github.com/opencv/opencv/commit/03130548eaa89e5491f669bf96af324890a26374
>  https://github.com/opencv/ade/commit/7cecc9138b89e1946e3e515727bb69b2ab119806
> 1.
> {noformat}
> In file included from 
> /home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.cc:9:
> /home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:65:7:
>  error: ‘uint8_t’ does not name a type
>    65 | const uint8_t kNoEntry = 255;
>       |       ^~~~~~~
> /home/szaszm/nifi-minifi-cpp/build/thirdparty/rocksdb-src/table/block_based/data_block_hash_index.h:1:1:
>  note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to 
> ‘#include <cstdint>’?
>   +++ |+#include <cstdint>
>     1 | // Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
> {noformat}
> 2.
> {noformat}
> In file included from 
> /home/szaszm/nifi-minifi-cpp/libminifi/include/agent/agent_docs.h:24,
>                  from 
> /home/szaszm/nifi-minifi-cpp/libminifi/src/agent/agent_docs.cpp:18:
> /home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:6: 
> warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ 
> keyword
>    30 | enum class Input : uint8_t {
>       | ~~~~ ^~~~~
>       |      -----
> /home/szaszm/nifi-minifi-cpp/libminifi/include/core/Annotation.h:30:18: 
> error: found ‘:’ in nested-name-specifier, expected ‘::’
>    30 | enum class Input : uint8_t {
>       |                  ^
>       |                  ::
> {noformat}
> 3.
> {noformat}
> In file included from 
> /home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.cc:16:
> /home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:6:
>  warning: elaborated-type-specifier for a scoped enum must not use the 
> ‘class’ keyword
>    34 | enum class FormatConversionChar : uint8_t;
>       | ~~~~ ^~~~~
>       |      -----
> /home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:33:
>  error: found ‘:’ in nested-name-specifier, expected ‘::’
>    34 | enum class FormatConversionChar : uint8_t;
>       |                                 ^
>       |                                 ::
> /home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:34:12:
>  error: ‘FormatConversionChar’ has not been declared
>    34 | enum class FormatConversionChar : uint8_t;
>       |            ^~~~~~~~~~~~~~~~~~~~
> /home/szaszm/nifi-minifi-cpp/build/_deps/absl-src/absl/strings/internal/str_format/extension.h:35:6:
>  warning: elaborated-type-specifier for a scoped enum must not use the 
> ‘class’ keyword
>    35 | enum class FormatConversionCharSet : uint64_t;
>       | ~~~~ ^~~~~
>       |      -----
> {noformat}
> 4.
> {noformat}
> In file included from 
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/passes/topological_sort.hpp:17,
>                  from 
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/source/topological_sort.cpp:7:
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:101:10:
>  error: ‘uintptr_t’ in namespace ‘std’ does not name a type
>   101 |     std::uintptr_t m_srcGraph;
>       |          ^~~~~~~~~
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:22:1:
>  note: ‘std::uintptr_t’ is defined in header ‘<cstdint>’; did you forget to 
> ‘#include <cstdint>’?
>    21 | #include "typed_metadata.hpp"
>   +++ |+#include <cstdint>
>    22 |
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:
>  In member function ‘const ade::Graph& 
> ade::ConstTypedGraph<Types>::getCGraph() const’:
> /home/szaszm/nifi-minifi-cpp/build/extensions/opencv/opencv-external-prefix/src/opencv-external-build/3rdparty/ade/ade-0.1.1f/sources/ade/include/ade/typed_graph.hpp:106:53:
>  error: ‘m_srcGraph’ was not declared in this scope
>   106 |         return *reinterpret_cast<const ade::Graph*>(m_srcGraph);
>       |                                                     ^~~~~~~~~~
> {noformat}
> workaround: 
> {code:sh}
> export CXXFLAGS="-include cstdint"
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to