[
https://issues.apache.org/jira/browse/NIFI-11528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722884#comment-17722884
]
Daniel Stieglitz commented on NIFI-11528:
-----------------------------------------
[~exceptionfactory] Thanks for the reminder. Looking more closely at the code
makes me feel the author chose an incorrect test case and the code is working
as expected. It is true that .75 milliseconds equals 750000 nanoseconds but
the point of method
{code:java}
makeWholeNumberTime
{code}
is not to find the smallest possible time unit but rather to find the next
smaller time unit with a whole number. The next possible smaller time unit
which has a whole number for .75 milliseconds is microseconds (not nanoseconds)
where the whole number is 750. I would think the test case should reflect the
conversion from milliseconds to microseconds. Please let me know whether you
concur. Thanks!
> Refactor Groovy tests in nifi-commons/nifi-utils to Java (and JUnit 5)
> ----------------------------------------------------------------------
>
> Key: NIFI-11528
> URL: https://issues.apache.org/jira/browse/NIFI-11528
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
