[ 
https://issues.apache.org/jira/browse/NIFI-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723087#comment-17723087
 ] 

ASF subversion and git services commented on NIFI-11380:
--------------------------------------------------------

Commit aefb278f325f70ea37356954f0cde772841e6afb in nifi's branch 
refs/heads/support/nifi-1.x from Matt Burgess
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=aefb278f32 ]

NIFI-11380: Refactor CaptureChangeMySQL with improvements

Backported
This closes #7116

Signed-off-by: Nandor Soma Abonyi <[email protected]>


> Refactor CaptureChangeMySQL with improvements
> ---------------------------------------------
>
>                 Key: NIFI-11380
>                 URL: https://issues.apache.org/jira/browse/NIFI-11380
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>             Fix For: 1.latest, 2.latest
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The CaptureChangeMySQL processor can be improved in many ways:
> - Eliminate use of DistributedCacheClient
> - MySQLCDCUtils - delete this class. It’s unnecessary. Just put the single 
> method that exists in the parent class of the writers
> - Eliminate mutable member variables. Gather all state together into an 
> object and store that as a single volatile member variable.
> - The outputEvents method is a huge block of switch/case and if/then/else 
> blocks. Kill all of this. Create an interface that’s capable of handling a 
> given event type and have multiple implementations. Determine appropriate 
> impl and call the method.
> - Do not keep a bunch of member variables to “rollback local state”. Keep 
> this in variables. If we fail, no harm, no foul. If we succeed, then update 
> member variable.
> - Remove onStopped method, just annotate stop() method with @OnStopped. No 
> need for @OnShutdown
> - Change name of “hostname” property to "node", and don’t require the port! 
> Default to 3306.
> - Remove unused hasRun member variable



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to