adamdebreceni commented on code in PR #1568: URL: https://github.com/apache/nifi-minifi-cpp/pull/1568#discussion_r1196634949
########## docker/test/integration/features/minifi_controller.feature: ########## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Feature: MiNiFi Controller functionalities + Test MiNiFi Controller functionalities + + Background: + Given the content of "/tmp/output" is monitored + + Scenario: Flow config can be updated through MiNiFi controller + Given a GenerateFlowFile processor + And a file with the content "test" is present in "/tmp/input" + And controller socket properties are set up + When all instances start up + And MiNiFi config is updated through MiNiFi controller + Then a flowfile with the content "test" is placed in the monitored directory in less than 60 seconds + And the updated config is persisted + + Scenario: A component can be stopped + Given a GenerateFlowFile processor + And a file with the content "test" is present in "/tmp/input" + And controller socket properties are set up + When all instances start up + And the GenerateFlowFile component is stopped through MiNiFi controller + Then the GenerateFlowFile component is not running + And the FlowController component is running + + Scenario: If FlowController is stopped all other components are stopped + Given a GenerateFlowFile processor + And a file with the content "test" is present in "/tmp/input" + And controller socket properties are set up + When all instances start up + And the FlowController component is stopped through MiNiFi controller + And the FlowController component is started through MiNiFi controller + Then the GenerateFlowFile component is not running + And the FlowController component is not running + + Scenario: FlowController can be stopped and restarted + Given a GenerateFlowFile processor + And a file with the content "test" is present in "/tmp/input" + And controller socket properties are set up + When all instances start up + And the FlowController component is stopped through MiNiFi controller + And the FlowController component is started through MiNiFi controller + Then the GenerateFlowFile component is running + And the FlowController component is running Review Comment: this seems to do the same setup as the previous one, yet it expects the opposite result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
