dan-s1 commented on PR #7248: URL: https://github.com/apache/nifi/pull/7248#issuecomment-1559534215
@exceptionfactory Thank you! What about the other issue I brought up yesterday? Quoting the message: > I am about to check in the changes as requested but I noticed that there is a test by the same name in a different package nifi-commons/nifi-utils/src/test/java/org/apache/nifi/processor. It is also exercising nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/FormatUtils.java. I think though my unit test class is in the right package while that one is not. Shouldn't these two test classes be be combined into to one class and placed in the correct package? If so, should I also make this part of this PR? Also it looks like the unit tests in that other class could benefit with the use of JUnit 5 parameterized tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
