[
https://issues.apache.org/jira/browse/NIFI-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703136#comment-15703136
]
ASF GitHub Bot commented on NIFI-2975:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1274
NIFI-2975: Only start expiring FlowFiles after FlowFile Repository ha…
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
…s been restored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-2975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1274
----
commit 3e25f4951a81c976f90d3a0b55dee9be998ea873
Author: Mark Payne <[email protected]>
Date: 2016-11-28T21:15:05Z
NIFI-2975: Only start expiring FlowFiles after FlowFile Repository has been
restored
----
> NiFi attempts to expire FlowFiles before all have been restored
> ---------------------------------------------------------------
>
> Key: NIFI-2975
> URL: https://issues.apache.org/jira/browse/NIFI-2975
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Fix For: 1.2.0
>
>
> Occasionally, I have seen the following log message in logs/nifi-app.log:
> ERROR [Framework Task Thread Thread-1] o.a.n.controller.tasks.ExpireFlowFiles
> Failed to expire FlowFiles due to java.lang.IllegalStateException: Cannot
> update repository until record recovery has been performed
> java.lang.IllegalStateException: Cannot update repository until record
> recovery has been performed
> at
> org.wali.MinimalLockingWriteAheadLog.update(MinimalLockingWriteAheadLog.java:199)
> ~[nifi-write-ahead-log-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.repository.WriteAheadFlowFileRepository.updateRepository(WriteAheadFlowFileRepository.java:219)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.repository.WriteAheadFlowFileRepository.updateRepository(WriteAheadFlowFileRepository.java:187)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:357)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:299)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.tasks.ExpireFlowFiles.expireFlowFiles(ExpireFlowFiles.java:85)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.tasks.ExpireFlowFiles.expireFlowFiles(ExpireFlowFiles.java:90)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.tasks.ExpireFlowFiles.expireFlowFiles(ExpireFlowFiles.java:116)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.tasks.ExpireFlowFiles.run(ExpireFlowFiles.java:56)
> ~[nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> org.apache.nifi.controller.scheduling.StandardProcessScheduler$1.run(StandardProcessScheduler.java:115)
> [nifi-framework-core-1.0.0.2.0.1.0-12.jar:1.0.0.2.0.1.0-12]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_45]
> at
> java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_45]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [na:1.8.0_45]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [na:1.8.0_45]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_45]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_45]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]
> This appears to be due to the fact that we are attempting to expire FlowFiles
> before we have finished recovering all of the FlowFiles from the
> FlowFileRepository. This is not really harmful, as the expiration will just
> keep trying until it is successful. However, it does result in some alarming
> ERROR-level messages in the logs and needs to be resolved.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
