lordgamez commented on code in PR #1574:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1574#discussion_r1210454963
##########
docker/test/integration/ssl_utils/SSL_cert_utils.py:
##########
@@ -110,7 +110,7 @@ def make_ca(common_name):
return ca_cert, ca_key
-def make_cert(common_name, ca_cert, ca_key):
+def _make_cert(common_name, ca_cert, ca_key, is_server_auth=True,
is_client_auth=True):
Review Comment:
This was an issue when upgrading to OpenSSL 3, when both were used the SSL
handshake failed, only the client or server specific auth should be added.
(Sorry I didn't elaborate before, we had this discussion previously with
@martinzink in person :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
