szaszm commented on code in PR #1581:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211836375
##########
libminifi/test/unit/ThreadPoolTests.cpp:
##########
@@ -84,7 +81,33 @@ TEST_CASE("ThreadPoolTest2", "[TPT2]") {
utils::Worker<int> functor(f_ex, "id", std::move(after_execute));
pool.start();
std::future<int> fut;
- pool.execute(std::move(functor), fut); // NOLINT(bugprone-use-after-move)
+ pool.execute(std::move(functor), fut);
fut.wait();
REQUIRE(20 == fut.get());
}
+
+TEST_CASE("Worker wait time should be relative to the last run") {
+ std::mutex cv_m;
+ std::condition_variable cv;
Review Comment:
You could use `std::promise<void>` or `std::atomic_flag` (like #1576) for a
simpler code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
