exceptionfactory commented on code in PR #7313:
URL: https://github.com/apache/nifi/pull/7313#discussion_r1213328201
##########
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProperties.java:
##########
@@ -114,4 +126,108 @@ public static PropertyDescriptor
getDynamicPropertyDescriptor(final String prope
.build();
}
+ private static class JndiJmsContextFactoryValidator implements Validator {
+ private static final String DEFAULT_DISALLOWED_CONTEXT_FACTORY =
"LdapCtxFactory";
+
+ private static final String DISALLOWED_CONTEXT_FACTORY;
+
+ static {
+ DISALLOWED_CONTEXT_FACTORY =
System.getProperty(CONTEXT_FACTORY_DISALLOWED_PROPERTY,
DEFAULT_DISALLOWED_CONTEXT_FACTORY);
+ }
+
+ @Override
+ public ValidationResult validate(final String subject, final String
input, final ValidationContext context) {
+ final ValidationResult.Builder builder = new
ValidationResult.Builder().subject(subject).input(input);
+
+ if (input == null || input.isEmpty()) {
+ builder.valid(false);
+ builder.explanation("Context Factory is required");
+ } else if (input.endsWith(DISALLOWED_CONTEXT_FACTORY)) {
Review Comment:
Thanks for highlighting this concern. On further evaluation, after
implementing the ability to override the default validation using Java System
properties, it seems better to limit the validation to the URL schemes. The
latest commit removes this validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
