mattyb149 commented on code in PR #7334:
URL: https://github.com/apache/nifi/pull/7334#discussion_r1214647825
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -119,7 +119,7 @@
<logger name="org.apache.nifi.processors.standard.LogAttribute"
level="INFO"/>
<logger name="org.apache.nifi.processors.standard.LogMessage"
level="INFO"/>
<logger
name="org.apache.nifi.controller.repository.StandardProcessSession"
level="WARN" />
-
+ <logger name="org.apache.parquet.hadoop.InternalParquetRecordReader"
level="WARN" />
Review Comment:
Can we add a comment here as to why we're changing this level (i.e. highly
unnecessary INFO-level logging done by this class)?
##########
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/stream/NifiSeekableInputStream.java:
##########
@@ -29,11 +29,11 @@ public class NifiSeekableInputStream extends
DelegatingSeekableInputStream {
public NifiSeekableInputStream(final ByteCountingInputStream input) {
super(input);
this.input = input;
- this.input.mark(Integer.MAX_VALUE);
+ this.input.mark(8192);
Review Comment:
Maybe create a constant since it's used more than once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
