szaszm commented on code in PR #1586:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1223088139
##########
libminifi/include/utils/TimeUtil.h:
##########
@@ -189,6 +189,20 @@ inline bool unit_matches<std::chrono::days>(const
std::string& unit) {
return unit == "d" || unit == "day" || unit == "days";
}
+template<>
+inline bool unit_matches<std::chrono::weeks>(const std::string& unit) {
+ return unit == "w" || unit == "week" || unit == "weeks";
+}
+
+template<>
+inline bool unit_matches<std::chrono::months>(const std::string& unit) {
+ return unit == "mon" || unit == "month" || unit == "months";
+}
+
+template<>
+inline bool unit_matches<std::chrono::years>(const std::string& unit) {
+ return unit == "y" || unit == "year" || unit == "years";
+}
Review Comment:
I'd remove "mon" and "mons", at least until they appear in NiFi. They're not
clear/common enough IMO, and they're one typo away from "min"/"mins".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
