lordgamez commented on code in PR #1588:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1588#discussion_r1228377107
##########
docker/DockerBuild.sh:
##########
@@ -168,6 +169,22 @@ else
DOCKERFILE="Dockerfile"
fi
+if [ -n "${DOCKER_BASE_IMAGE}" ]; then
+ if [ -z "${DISTRO_NAME}" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_ALPINE_IMAGE=${DOCKER_BASE_IMAGE}")
+ elif [ "${DISTRO_NAME}" == "bionic" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_BIONIC_IMAGE=${DOCKER_BASE_IMAGE}")
+ elif [ "${DISTRO_NAME}" == "centos" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_CENTOS_IMAGE=${DOCKER_BASE_IMAGE}")
+ elif [ "${DISTRO_NAME}" == "fedora" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_FEDORA_IMAGE=${DOCKER_BASE_IMAGE}")
+ elif [ "${DISTRO_NAME}" == "focal" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_FOCAL_IMAGE=${DOCKER_BASE_IMAGE}")
+ elif [ "${DISTRO_NAME}" == "rockylinux" ]; then
+ BUILD_ARGS+=("--build-arg" "BASE_ROCKYLINUX_IMAGE=${DOCKER_BASE_IMAGE}")
+ fi
+fi
+
Review Comment:
Good point, I was afraid it would break something, but the
`BASE_ALPINE_IMAGE` should not have been used separately so changed it in
d1ba15fb7ecf7f719e3e9991e04a51a7c0bce29b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
