markap14 commented on code in PR #7315:
URL: https://github.com/apache/nifi/pull/7315#discussion_r1229795456
##########
nifi-registry/nifi-registry-core/nifi-registry-flow-diff/src/main/java/org/apache/nifi/registry/flow/diff/StandardFlowComparator.java:
##########
@@ -522,6 +522,8 @@ private void compare(final VersionedProcessGroup groupA,
final VersionedProcessG
addIfDifferent(differences,
DifferenceType.DEFAULT_BACKPRESSURE_OBJECT_COUNT_CHANGED, groupA, groupB,
VersionedProcessGroup::getDefaultBackPressureObjectThreshold, true, 10_000L);
addIfDifferent(differences,
DifferenceType.DEFAULT_FLOWFILE_EXPIRATION_CHANGED, groupA, groupB,
VersionedProcessGroup::getDefaultFlowFileExpiration, true, "0 sec");
addIfDifferent(differences, DifferenceType.PARAMETER_CONTEXT_CHANGED,
groupA, groupB, VersionedProcessGroup::getParameterContextName, true, null);
+ addIfDifferent(differences, DifferenceType.LOG_TO_OWN_FILE_CHANGED,
groupA, groupB, VersionedProcessGroup::isLogToOwnFile, true, Boolean.FALSE);
+ addIfDifferent(differences, DifferenceType.LOG_FILE_SUFFIX_CHANGED,
groupA, groupB, VersionedProcessGroup::getLogFileSuffix, true,
groupA.getName());
Review Comment:
While we do want to capture these as Flow Differences, they really are
environmental. So these should be added to the
`FlowDifferenceFilters.isEnvironmentalChange` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
