markap14 commented on code in PR #7253:
URL: https://github.com/apache/nifi/pull/7253#discussion_r1229844503
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/SystemDiagnosticsSnapshotDTO.java:
##########
@@ -538,6 +549,93 @@ public StorageUsageDTO clone() {
}
}
+ @XmlType(name = "resourceClaimDetails")
+ public static class ResourceClaimDetailsDTO implements Cloneable {
+ private String container;
+ private String section;
+ private String identifier;
+ private Boolean inUse;
+ private Boolean awaitingDestruction;
+ private Boolean writable;
Review Comment:
For better or worse, we use Object representations of all field values in
DTOs. Very early on, it was determined that the DTO should contain no logic -
even providing default values for primitives, which is what happens if using a
primitive type. Rather, the DTO should simply convey exactly what was set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
