exceptionfactory commented on PR #7194: URL: https://github.com/apache/nifi/pull/7194#issuecomment-1595134094
Thanks for moving the `VolatileSchemaCache` back to the record services module. The latest code changes look good. In the course of review, I noticed that `nifi-poi-services` was not included in `nifi-poi-nar`, so it wasn't being picked up at runtime. I also noticed that the `Required Sheets` property was not being evaluated with the attributes passed to the `createRecordReader` method. I pushed a commit correcting those two issues, along with adjusting spacing and adding the `final` keyword in a few places. With those changes, this should be ready to go, and I will plan on merging pending successful build completion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
