ChrisSamo632 commented on PR #7045: URL: https://github.com/apache/nifi/pull/7045#issuecomment-1597685949
Looking at #5775, the main difference there is that it tried to introduce the ability to let the user define where the token file was located on the NiFi server/in the NiFi container. This **can** be defined through the `AWS_WEB_IDENTITY_TOKEN_FILE` environment variable as you indicate @zhangzhonglai, but not everyone will want/be able to use that approach - so the use of the configurable setting within the `AWSCredentialsProviderControllerService` would be a sensible addition and more in-fitting with how NiFi tries to make things configurable. It might be worth considering rejuvinating @nuttybrewer's PR and include your additional dependenies to allow the use of the default env vars as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
