Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1281#discussion_r90273518
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JdbcCommon.java
 ---
    @@ -284,7 +291,7 @@ public static Schema createSchema(final ResultSet rs, 
String recordName, boolean
                         break;
     
                     case INTEGER:
    -                    if (meta.isSigned(i)) {
    +                    if (!dbAdapter.getSupportsMetaDataColumnIsSigned() || 
meta.isSigned(i)) {
    --- End diff --
    
    If the DB doesn't support isSigned(), should we treat them all as Longs? I 
assume it's done this way if Hive returns INTEGER as the type and Integer 
objects for values. I wonder if there's another DB that doesn't support 
isSigned() and could return Long objects. In that case we might want another 
check for getSupportsMetaDataColumnIsSigned() (and for the type of object) when 
storing the values into the record.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to