exceptionfactory commented on code in PR #7401:
URL: https://github.com/apache/nifi/pull/7401#discussion_r1245593903
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java:
##########
@@ -2024,7 +2029,13 @@ public Response createProcessGroup(
}
}
- // Step 4: Resolve Bundle info
+ // Step 4: Replace parameter contexts if necessary
+ if (!keepExistingParameterContext) {
+ final ParameterContextReplacementUtil
parameterContextReplacementUtil =
ParameterContextReplacementUtil.getInstance(serviceFacade);
Review Comment:
This approach to creating an instance of ParameterContextReplacementUtil
seems contrary to other conventions. It seems like it would be better to make
the ParameterContext Replacement operations into an interface that could be
injected. As it is, coupling the entire Service Facade to the Parameter Context
Replacement instantiation is problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
