emiliosetiadarma commented on PR #7446: URL: https://github.com/apache/nifi/pull/7446#issuecomment-1612201484
I made the changes while still preserving `KeyStoreScanner` and `TrustStoreScanner` as the derived classes for two reasons. 1. So the logger is class-specific 2. So the `server` would have beans with distinct types. Having all have the same type would cause some existing tests to fail since it uses `server.getBean`. Some thoughts: I was wondering if we were to have just one class whether it's a good idea to have both a keystore scanner and truststore scanner in the same class. One advantage this would have is if both keystore and truststore changed, then the `SSLContext` would be reloaded only once, as opposed to having two scanners that reloaded it twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
