szaszm commented on code in PR #1587:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1246666838
##########
docker/test/integration/cluster/checkers/PrometheusChecker.py:
##########
@@ -18,7 +18,16 @@
class PrometheusChecker:
def __init__(self):
- self.prometheus_client =
PrometheusConnect(url="http://localhost:9090";, disable_ssl=True)
+ self.use_ssl = False
+
+ def enable_ssl(self):
+ self.use_ssl = True
+
+ def _getClient(self):
+ if self.use_ssl:
+ return PrometheusConnect(url="https://localhost:9090";,
disable_ssl=True)
Review Comment:
Do we even need the option of using SSL on the prometheus listener? It
doesn't interact with minifi, since prometheus is the client in the metrics
collection, and it doesn't need client certificates either. Why don't we just
throw out the ssl option in PrometheusChecker altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
