[
https://issues.apache.org/jira/browse/NIFI-11767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739645#comment-17739645
]
David Handermann commented on NIFI-11767:
-----------------------------------------
Yes, the different methods test different inputs. As long as all tests use
public methods, and maintain the existing coverage of different inputs, the
best approach seems to be one method with all potential parameters. Separate
methods also works if that makes the tests clearer.
> Refactor Groovy tests in nifi-web-error and nifi-web-security to Java (and
> JUnit 5)
> -----------------------------------------------------------------------------------
>
> Key: NIFI-11767
> URL: https://issues.apache.org/jira/browse/NIFI-11767
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> The following tests are to be refactored
> #
> /nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-error/src/test/groovy/org/apache/nifi/web/filter/CatchAllFilterTest.groovy
> #
> ./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/groovy/org/apache/nifi/web/security/ProxiedEntitiesUtilsTest.groovy
> #
> ./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/groovy/org/apache/nifi/web/security/requests/ContentLengthFilterTest.groovy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
