lordgamez commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1258396345
##########
extensions/azure/processors/ListAzureBlobStorage.h:
##########
@@ -27,31 +27,42 @@
#include <vector>
#include "core/Property.h"
+#include "core/PropertyDefinition.h"
#include "AzureBlobStorageProcessorBase.h"
#include "core/logging/LoggerConfiguration.h"
namespace org::apache::nifi::minifi::azure::processors {
+namespace azure {
+SMART_ENUM(EntityTracking,
+ (NONE, "none"),
+ (TIMESTAMPS, "timestamps")
+)
+} // namespace azure
Review Comment:
This definition makes the `EntityTracking` part of namespace
`org::apache::nifi::minifi::azure::processors::azure` where `azure` is
duplicated, I'm not sure that's a good idea. I think it would be better to have
it in the `org::apache::nifi::minifi::azure` namespace like:
```
namespace org::apache::nifi::minifi::azure {
SMART_ENUM(EntityTracking,
(NONE, "none"),
(TIMESTAMPS, "timestamps")
)
namespace processors {
...
} // namespace processors
} // namespace org::apache::nifi::minifi::azure
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
