lordgamez commented on code in PR #1586:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1259296645
##########
extensions/aws/processors/PutS3Object.h:
##########
@@ -97,54 +111,46 @@ class PutS3Object : public S3Processor {
class ReadCallback {
public:
- static constexpr uint64_t MAX_SIZE = 5_GiB;
- static constexpr uint64_t BUFFER_SIZE = 4_KiB;
-
- ReadCallback(uint64_t flow_size, const
minifi::aws::s3::PutObjectRequestParameters& options, aws::s3::S3Wrapper&
s3_wrapper)
- : flow_size_(flow_size)
- , options_(options)
- , s3_wrapper_(s3_wrapper) {
+ ReadCallback(uint64_t flow_size, const
minifi::aws::s3::PutObjectRequestParameters& options, aws::s3::S3Wrapper&
s3_wrapper,
+ uint64_t multipart_threshold, uint64_t multipart_size,
core::logging::Logger& logger)
Review Comment:
Updated in 0464ed5fc57b119da618142c671f2b985b4ae127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
