exceptionfactory commented on PR #7458: URL: https://github.com/apache/nifi/pull/7458#issuecomment-1635947161
> During testing, I found it a bit cumbersome that the `File Name` and `Blob Name` name properties are on the processor while the source path is in the service. In my mind, they are logically connected, especially in this case. Purely from the user's point of view, I think it would be better to put these fields into the FileResourceService, though I understand it is not possible as it resides in a separate module. Tbh, I don't have a good idea to solve it atm, but I wanted to point it out. Thanks for the feedback and testing @nandorsoma! I pushed an update that removes two utility methods and instead uses the functional `Optional.map().orElse()` approach. This seems more natural under the circumstances. This optional approach to file transfer is somewhat outside the bounds of normal processing, given that the `StandardFileResourceService` allows reading directly from the file system, so I understand how the property organization may not be the most intuitive. The correct configuration does require aligning the Service `File Path` with the expected input values on a given FlowFile, but that seems reasonable given that standard usage patterns will not make use of this feature. There could be room for improvement in subsequent iterations, but at least the current approach avoids introducing new permission restrictions on the existing Processors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
