EndzeitBegins commented on PR #7481: URL: https://github.com/apache/nifi/pull/7481#issuecomment-1636682094
@exceptionfactory Thanks for the quick review. I understand. I was thinking the same, but assumed it might be okay-ish due to the fact, that the test library used `embedded-redis` does the same. I'll take a look at replacing `embedded-redis`, which hasn't seen maintenance for a long time by the way, with Testcontainers. If that proves to time consuming I'd propose to remove the binary and `@Disable` the one test that requires a newer version completely, with an hint that in order to execute it, one must provide a newer binary locally. I think it's a good thing to at least have a test case that reproduces an undesired behaviour, before fixing it. Would you be fine with both approaches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
