bbende commented on code in PR #7495:
URL: https://github.com/apache/nifi/pull/7495#discussion_r1267228050
##########
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/ConfluentSchemaRegistryStrategy.java:
##########
@@ -67,7 +67,7 @@ public RecordSchema getSchema(final Map<String, String>
variables, final InputSt
final int schemaId = bb.getInt();
final SchemaIdentifier schemaIdentifier = SchemaIdentifier.builder()
- .id(Long.valueOf(schemaId))
+ .schemaVersionId(Long.valueOf(schemaId))
.version(1)
Review Comment:
I'm wondering if we can also remove this hard-coded version 1, I don't think
it was even used for anything before, but now that we are switching to
`schemaVersionId`, it should definitely not be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
