fgerlits opened a new pull request, #1610: URL: https://github.com/apache/nifi-minifi-cpp/pull/1610
https://issues.apache.org/jira/browse/MINIFICPP-2134 If the value of a typed property (Time Period, Data Size, Port etc) is set, but to an invalid value, then we should throw in getProperty<T>(). In some cases, we were using a typed getProperty<T>(), but the corresponding PropertyDefinition did not have a PropertyType, so the C2 server had no way of validating the property. In these cases, I have kept the current behavior, which is to treat the invalid value as if no value was set -- but I have also added the PropertyType to the PropertyDefinition so we can add validation in a later release. Additionally, the Max Poll Records property of ConsumeKafka used to internally treat the value as uint64, but in the manifest we sent a uint32 validator; I have changed the validator to be uint64 ("unsigned long"), as well. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
