ASF GitHub Bot commented on NIFI-3140:

GitHub user mattyb149 opened a pull request:


    NIFI-3140: Restored optional type handling in FetchElasticsearchHttp

    Thank you for submitting a contribution to Apache NiFi.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [x] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-3140

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1288
commit 8f0db002a4abb571980f0d2fe61c864f20b77693
Author: Matt Burgess <mattyb...@apache.org>
Date:   2016-12-02T00:32:49Z

    NIFI-3140: Restored optional type handling in FetchElasticsearchHttp


> FetchElasticsearchHttp no longer accepts optional type
> ------------------------------------------------------
>                 Key: NIFI-3140
>                 URL: https://issues.apache.org/jira/browse/NIFI-3140
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>             Fix For: 1.2.0
> In NiFi 1.1.0, if the Type property is omitted from the 
> FetchElasticsearchHttp configuration (and a specific index is specified 
> rather than _all), the processor fails with an error "400 Bad Request".
> This is a result of FetchElasticsearchHttp URL building being aligned with 
> those used in the Query/ScrollElasticsearchHttp processors (added in 
> NIFI-2417). Unfortunately the REST API is not consistent between the Get and 
> Search APIs.
> For FetchElasticsearchHttp, the logic should be restored to insert a path 
> segment of "_all" if the Type is not provided, and the Index property 
> description should be reverted to not imply the use of "_all". Although it is 
> possible to issue a successful Get against all indexes, it cannot have a type 
> or document ID specified, and even then it does not return a document but 
> instead a listing of indexes, which is inconsistent with the purpose of the 
> processor.

This message was sent by Atlassian JIRA

Reply via email to