markap14 commented on PR #7191: URL: https://github.com/apache/nifi/pull/7191#issuecomment-1658632218
@tpalfy I have been playing with this some today. First time that I've played with this PR in a while. Generally, I think things are looking good. But I do have one major-ish concern, which I think is easy to rectify. As is, in this PR there is only a single rule - Disallow Component. I think this is reasonable. I set it to disallow GenerateFlowFile and set the Enforcement Policy to 'Enforce'. The GenerateFlowFile processor that I had, and all that I added, became invalid because the processor was not allowed. Perfect. I then changed the Enforcement Policy to 'Warn'. But now, nothing happens. There is no warning. If I am not mistaken, the intent here is to build out a more full and robust UI that will provide more insights, information, etc. from these warnings in a follow-on PR. But the concern that I have right now is that as-is, I can create the rule and set the Enforcement Policy to 'Warn' and it does nothing. And this leads to a lot of questions. I think we need to address this before merging this PR. I think we could use either of two approaches: 1) Hide the 'Flow Analysis Rules' tab until we have the full feature built into the UI. Or 2) Remove 'Warn' from the available "Enforcement Policy" drop-down, leaving only "Enforce" (or potentially even removing the drop-down for now and hard-coding to "Enforce"). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
