TamasNeumer commented on PR #7545: URL: https://github.com/apache/nifi/pull/7545#issuecomment-1661814686
When creating the `ResultSetRecordSet` object, the default `defaultScale` was `0`. Previously if the `resultSetScale` was `0` then the default (`0`) `defaultScale` was applied. Therefore I created a new test (`testCreateSchemaWhenScaleIsNonDefault`), where the scale is set. With the old code (`decimalScale = resultSetScale > 0 ? resultSetScale : defaultScale;`) the test fails, whereas with the fix (`decimalScale = resultSetScale >= 0 ? resultSetScale : defaultScale;`) it passes. I hope this is sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
