[
https://issues.apache.org/jira/browse/NIFI-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716162#comment-15716162
]
ASF GitHub Bot commented on NIFI-3132:
--------------------------------------
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1292
NIFI-3132 - Using cygpath and quoting paths correctly in sh scripts w…
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] - N/A - Have you written or updated unit tests to verify your changes?
- [x] - N/A - If adding new dependencies to the code, are these
dependencies licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] - N/A - If applicable, have you updated the LICENSE file, including
the main LICENSE file under nifi-assembly?
- [x] - N/A - If applicable, have you updated the NOTICE file, including
the main NOTICE file found under nifi-assembly?
- [x] - N/A - If adding new Properties, have you added .displayName in
addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] - N/A - Have you ensured that format looks appropriate for the output
in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
…hen run in cygwin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3132
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1292
----
commit 3eef9a29126effdde4b49d609865877e7718376a
Author: Bryan Rosander <[email protected]>
Date: 2016-12-02T19:43:22Z
NIFI-3132 - Using cygpath and quoting paths correctly in sh scripts when
run in cygwin
----
> nifi.sh resolves log directory incorrectly in cygwin
> ----------------------------------------------------
>
> Key: NIFI-3132
> URL: https://issues.apache.org/jira/browse/NIFI-3132
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Bryan Rosander
> Assignee: Bryan Rosander
> Priority: Minor
>
> Running in cygwin results in the incorrect directory used for log directory.
> The other relative paths appear to resolve properly.
> Please see org.apache.nifi.bootstrap.config.log.dir compared to other paths.
> This results in logs being created at:
> C:\cygdrive\c\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\logs
> instead of:
> C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\logs
> {code}
> bryan@bryan-win-vm /cygdrive/c/Users/bryan/Downloads/nifi-1.1.0-bin/nifi-1.1.0
> $ bin/nifi.sh run
> Java home: /cygdrive/c/Program Files/Java/jdk1.8.0_92
> NiFi home: C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0
> Bootstrap Config File:
> C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\conf\bootstrap.conf
> 2016-11-30 09:57:54,528 INFO [main] org.apache.nifi.bootstrap.Command
> Starting Apache NiFi...
> 2016-11-30 09:57:54,528 INFO [main] org.apache.nifi.bootstrap.Command Working
> Directory: C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0
> 2016-11-30 09:57:54,528 INFO [main] org.apache.nifi.bootstrap.Command
> Command: java -classpath
> C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\conf;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\jcl-over-slf4j-1.7.12.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\jul-to-slf4j-1.7.12.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\log4j-over-slf4j-1.7.12.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\logback-classic-1.1.3.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\logback-core-1.1.3.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-api-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-documentation-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-framework-api-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-nar-utils-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-properties-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\nifi-runtime-1.1.0.jar;C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\lib\slf4j-api-1.7.12.jar
> -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m -Xms512m
> -Dsun.net.http.allowRestrictedHeaders=true -Djava.net.preferIPv4Stack=true
> -Djava.awt.headless=true -XX:+UseG1GC
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dnifi.properties.file.path=C:\Users\bryan\Downloads\nifi-1.1.0-bin\nifi-1.1.0\.\conf\nifi.properties
> -Dnifi.bootstrap.listen.port=50031 -Dapp=NiFi
> -Dorg.apache.nifi.bootstrap.config.log.dir=/cygdrive/c/Users/bryan/Downloads/nifi-1.1.0-bin/nifi-1.1.0/logs
> org.apache.nifi.NiFi
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
