fgerlits commented on PR #1620: URL: https://github.com/apache/nifi-minifi-cpp/pull/1620#issuecomment-1665754649
> Could we document the `SSL_CERT_DIR` and `SSL_CERT_FILE` environment variable options for setting the certificate somewhere? Maybe write a test using those variables as well? I was planning to do that, but it would take quite a bit of additional code to create automatic tests for this, as it requires that none of the paths listed in `utils::getDefaultCAPath()` exists (so we'd have to remove it), and also we'd need to create a mechanism for setting environment variables in the MiNiFi container. I don't think we want to encourage people to use the `SSL_CERT_DIR` and `SSL_CERT_FILE` environment variables; setting the `CA Certificate` property in `SSLContextService` or the `SSL Certificate Authority` property in `ListenHTTP` is a better option. I have tested these manually because in case there is a production issue we need a quick temporary solution for, it's good to know we have this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
