turcsanyip commented on code in PR #7583: URL: https://github.com/apache/nifi/pull/7583#discussion_r1287362557
########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-common/pom.xml: ########## @@ -0,0 +1,133 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-bundle</artifactId> + <version>2.0.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-iceberg-common</artifactId> + <packaging>jar</packaging> + + <dependencies> + <!-- Internal dependencies --> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-utils</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record-serialization-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-services-api</artifactId> + <version>2.0.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-kerberos-user-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos</artifactId> Review Comment: `nifi-security-kerberos` is not used in the module directly (from the code). For this reason, I would not add it explicitly. `nifi-hadoop-utils` brings it in transitively. ########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/pom.xml: ########## @@ -52,49 +52,34 @@ </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-kerberos-user-service-api</artifactId> + <artifactId>nifi-iceberg-common</artifactId> + <version>2.0.0-SNAPSHOT</version> </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-security-kerberos-api</artifactId> + <artifactId>nifi-kerberos-user-service-api</artifactId> </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-security-kerberos</artifactId> - <version>2.0.0-SNAPSHOT</version> + <artifactId>nifi-security-kerberos-api</artifactId> </dependency> <dependency> - <groupId>org.apache.nifi</groupId> - <artifactId>nifi-hadoop-utils</artifactId> - <version>2.0.0-SNAPSHOT</version> + <groupId>org.apache.hadoop</groupId> + <artifactId>hadoop-hdfs</artifactId> + <version>${hadoop.version}</version> + <scope>provided</scope> + <exclusions> + <exclusion> + <groupId>log4j</groupId> + <artifactId>log4j</artifactId> + </exclusion> + <exclusion> + <groupId>commons-logging</groupId> + <artifactId>commons-logging</artifactId> + </exclusion> + </exclusions> Review Comment: `hadoop-hdfs` is only needed for tests (the module compiles without it). Also, it is not present at runtime in any parent nars (so it is not provided). That's why `test` scope would be the right one. Please also move the dependency to the "Test dependencies" section. ########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/pom.xml: ########## @@ -52,49 +52,34 @@ </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-kerberos-user-service-api</artifactId> + <artifactId>nifi-iceberg-common</artifactId> + <version>2.0.0-SNAPSHOT</version> </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-security-kerberos-api</artifactId> + <artifactId>nifi-kerberos-user-service-api</artifactId> Review Comment: It seems to be needed for tests only. `test` scope could be used. ########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/pom.xml: ########## @@ -52,49 +52,34 @@ </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-kerberos-user-service-api</artifactId> + <artifactId>nifi-iceberg-common</artifactId> + <version>2.0.0-SNAPSHOT</version> </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-security-kerberos-api</artifactId> + <artifactId>nifi-kerberos-user-service-api</artifactId> </dependency> <dependency> <groupId>org.apache.nifi</groupId> - <artifactId>nifi-security-kerberos</artifactId> - <version>2.0.0-SNAPSHOT</version> + <artifactId>nifi-security-kerberos-api</artifactId> Review Comment: `nifi-security-kerberos-api` does not seem to be needed in this module. I cannot see class imports, the module compiles and the tests run without it. I think it can be removed. ########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-common/pom.xml: ########## @@ -0,0 +1,133 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-bundle</artifactId> + <version>2.0.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-iceberg-common</artifactId> + <packaging>jar</packaging> + + <dependencies> + <!-- Internal dependencies --> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-utils</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record-serialization-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-services-api</artifactId> + <version>2.0.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-kerberos-user-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>commons-lang</groupId> + <artifactId>commons-lang</artifactId> Review Comment: Minor: not an internal dependency so it is in wrong section. ########## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-common/pom.xml: ########## @@ -0,0 +1,133 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-bundle</artifactId> + <version>2.0.0-SNAPSHOT</version> + </parent> + + <artifactId>nifi-iceberg-common</artifactId> + <packaging>jar</packaging> + + <dependencies> + <!-- Internal dependencies --> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-utils</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record-serialization-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-iceberg-services-api</artifactId> + <version>2.0.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-kerberos-user-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-kerberos</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>commons-lang</groupId> + <artifactId>commons-lang</artifactId> + <version>2.6</version> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-hadoop-utils</artifactId> + <version>2.0.0-SNAPSHOT</version> + </dependency> + + <!-- External dependencies --> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-data</artifactId> + <version>${iceberg.version}</version> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-parquet</artifactId> + <version>${iceberg.version}</version> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-orc</artifactId> + <version>${iceberg.version}</version> + </dependency> + <dependency> + <groupId>org.apache.iceberg</groupId> + <artifactId>iceberg-core</artifactId> Review Comment: Minor: could you please move `iceberg-core` and `iceberg-hive-metastore` to the beginning of external section? (as the iceberg-* dependencies were in the processors module) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
