turcsanyip commented on code in PR #7588: URL: https://github.com/apache/nifi/pull/7588#discussion_r1295881670
########## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/flow/resource/hadoop/HDFSResourceInputStream.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.flow.resource.hadoop; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.nifi.processors.hadoop.HDFSResourceHelper; + +final class HDFSResourceInputStream extends InputStream { + private final FileSystem fileSystem; + private final FSDataInputStream payload; + + HDFSResourceInputStream(final FileSystem fileSystem, final FSDataInputStream payload) { Review Comment: Minor: `payload` is rather used for data, not for a wrapped object, in my opinion. `fsDataInputStream` / `inputStream` / `wrappedInputStream` ? ########## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/flow/resource/hadoop/HDFSExternalResourceProvider.java: ########## @@ -16,6 +16,18 @@ */ package org.apache.nifi.flow.resource.hadoop; +import java.io.IOException; +import java.io.InputStream; +import java.net.InetSocketAddress; +import java.net.Socket; +import java.net.URI; +import java.security.PrivilegedExceptionAction; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; +import javax.net.SocketFactory; Review Comment: Please do not reorganize imports, only if they are in wrong order. "First 3rd party, then java" is common in NiFi as it was in the previous version of this class. Please revert the import changes in the other files too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
