szaszm commented on code in PR #1617: URL: https://github.com/apache/nifi-minifi-cpp/pull/1617#discussion_r1298336482
########## minifi_main/MiNiFiWindowsService.h: ########## @@ -20,6 +20,7 @@ #ifdef WIN32 #include <memory> +#include <Windows.h> Review Comment: What made this necessary? edit: if it's just HANDLE, that could be declared separately without pulling in the heavyweight windows headers. It's unlikely to ever change, since that would break most existing windows binaries. ```suggestion using HANDLE = void*; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
