dan-s1 commented on PR #7634: URL: https://github.com/apache/nifi/pull/7634#issuecomment-1687073953
I did not realize either. I worked off your original comment thinking it would be okay for the others. Aside from variables I am not sure how I would not reduce the scope of the methods whose scope had to change. I am not sure I understand everything going on in `PeerSelector` so I do not feel I would be the right one to refactor it. Is there anyway what I have done in this PR be used? I did get most of the tests to work by using Mockito which I thought be worthwhile to preserve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
