tpalfy commented on PR #7191: URL: https://github.com/apache/nifi/pull/7191#issuecomment-1689937919
Hi @mcgilman, With my last change I tried to addressed all concerns: > the sole Flow Analysis Rule available now does not support them. Those include: > > - Referencing a Controller Service from a Property. Added ControllerServiceReferencingFlowAnalysisRule > - Property verification of a Flow Analysis Rule. Added EnsureFlowAnalysisRuleConfigurationCorrect > - View/Reset State of a Flow Analysis Rule. Added StatefulFlowAnalysisRule > - Custom UI for a Flow Analysis Rule. Custom UI is not supported for Flow Analysis Rules > - Change Bundle/Version of a Flow Analysis Rule. This can be tested like with other components. We can build a nar (either nifi-standard-nar or nifi-system-test-extensions-nar) with a different version and add to an existing nifi installation. > - User Specified Sensitive Dynamic Properties Added SensitiveDynamicPropertiesFlowAnalysisRule > > Separately, I see that we've opted to hide `Warn` as an option in the Enforcement Policy. However, that value appears to be the default value for newly created Rules. With the `Warn` option removed, any subsequent changes to the Rule will update this but it looks like the initial value is not what we want it to be.this but it looks like the initial value is not what we want it to be. When Flow Analysis Rules are created via the UI the Enforcement Policy will be set to 'Enforce' so the initial value will be that. I understand that this relies on the UI but this is meant to be temporary and I didn't want to overcomplicate it so that the reversal can be done as smoothly as possible. Please let me know if I have missed something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
