[
https://issues.apache.org/jira/browse/MINIFICPP-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz resolved MINIFICPP-949.
------------------------------------
Resolution: Invalid
Infeasible to fix all at once
> Review our smart pointer usage
> ------------------------------
>
> Key: MINIFICPP-949
> URL: https://issues.apache.org/jira/browse/MINIFICPP-949
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Dániel Bakai
> Priority: Major
>
> * We have to avoid shared_ptr cycles
> * Don’t use shared_ptr indiscriminately, use weak_ptr where ownership is not
> really required
> * Analyze the code or wrap shared_ptr in Debug builds into an object with
> extra accounting to detect shared_ptr cycles
> * It would be better to create an architecture that “just works” instead of
> one where you have to take active action for it to work
> * We shouldn’t leak even if the Connections are not drained
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
