exceptionfactory commented on code in PR #7639:
URL: https://github.com/apache/nifi/pull/7639#discussion_r1303567399
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java:
##########
@@ -391,10 +391,11 @@ public class InvokeHTTP extends AbstractProcessor {
public static final PropertyDescriptor REQUEST_HEADER_ATTRIBUTES_PATTERN =
new PropertyDescriptor.Builder()
.name("Attributes to Send")
.displayName("Request Header Attributes Pattern")
- .description("Regular expression that defines which attributes to
send as HTTP headers in the request. "
- + "If not defined, no attributes are sent as headers.
Dynamic properties will be sent as headers. "
- + "The dynamic property name will be the header key and
the dynamic property value will be interpreted as expression "
- + "language will be the header value.")
+ .description("Regular expression that defines which FlowFile
attribute(s) to send as HTTP headers in the request. "
Review Comment:
```suggestion
.description("Regular expression that defines which FlowFile
attributes to send as HTTP headers in the request. "
```
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java:
##########
@@ -130,7 +130,8 @@
@Tags({"http", "https", "rest", "client"})
@InputRequirement(Requirement.INPUT_ALLOWED)
@CapabilityDescription("An HTTP client processor which can interact with a
configurable HTTP Endpoint. The destination URL and HTTP Method are
configurable."
- + " FlowFile attributes are converted to HTTP headers and the FlowFile
contents are included as the body of the request (if the HTTP Method is PUT,
POST or PATCH).")
+ + " When the HTTP Method is PUT, POST or PATCH, the FlowFile contents
are included as the body of the request and FlowFile attributes are converted"
+ + " to HTTP headers (optionally, if configured to be sent via the
'Attributes to Send' property)")
Review Comment:
It is worth noting that `Attributes to Send` is now different than the
display name `Request Header Attributes Pattern`. Perhaps just generalizing
this statement is the best approach.
```suggestion
+ " to HTTP headers based on configuration properties.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
