Lehel44 commented on code in PR #7644:
URL: https://github.com/apache/nifi/pull/7644#discussion_r1305612019
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -26,10 +26,15 @@
<packaging>jar</packaging>
<dependencies>
+ <!-- Internal dependencies -->
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-record</artifactId>
+ </dependency>
<dependency>
Review Comment:
nifi-utils is provided by nifi-standard-services-api-nar through nar
hierarchy
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -26,10 +26,15 @@
<packaging>jar</packaging>
<dependencies>
+ <!-- Internal dependencies -->
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-api</artifactId>
</dependency>
+ <dependency>
Review Comment:
nifi-record is provided by nifi-standard-services-api-nar through nar
hierarchy
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -49,6 +70,16 @@
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
+ <dependency>
+ <groupId>javax.json</groupId>
+ <artifactId>javax.json-api</artifactId>
+ <version>1.1.4</version>
+ </dependency>
+ <dependency>
+ <groupId>org.glassfish</groupId>
+ <artifactId>javax.json</artifactId>
+ <version>1.1.4</version>
+ </dependency>
Review Comment:
These dependencies can be removed
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -26,10 +26,15 @@
<packaging>jar</packaging>
<dependencies>
+ <!-- Internal dependencies -->
<dependency>
Review Comment:
nifi-api can be provided because the nifi-api-jar because it is loaded by
the system class loader
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -41,6 +46,22 @@
<version>2.0.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
+ <dependency>
Review Comment:
nifi-record-serialization-service-api is provided by
nifi-standard-services-api-nar through nar hierarchy
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -41,6 +46,22 @@
<version>2.0.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-record-serialization-service-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-record-path</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
Review Comment:
nifi-record-sink-api is provided by nifi-standard-services-api-nar through
nar hierarchy
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -49,6 +70,16 @@
<groupId>commons-io</groupId>
Review Comment:
I would remove this dependency since it's only used once in GetZendesk. The
IOUtils::toString can be replaced with the following approach.
```
try (InputStream responseBodyStream = response.body();
BufferedReader reader = new BufferedReader(new
InputStreamReader(responseBodyStream, StandardCharsets.UTF_8))) {
final String responseBody =
reader.lines().collect(Collectors.joining(System.lineSeparator()));
errorMessage = String.format("HTTP %s error for
requested URI [%s] with response [%s]", response.statusCode(), uri,
responseBody);
getLogger().warn(errorMessage);
}
```
##########
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/pom.xml:
##########
@@ -77,5 +108,10 @@
<artifactId>mockwebserver</artifactId>
Review Comment:
This one provides transitive vulnerable dependency to junit:4.13
https://devhub.checkmarx.com/cve-details/CVE-2020-15250
According to okhhtp3 Version 5.0.0-alpha.2
[changelogs](https://square.github.io/okhttp/changelogs/changelog/)
they removed it. We should upgrade to the next release when it's available
@exceptionfactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
