szaszm commented on code in PR #1648:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1648#discussion_r1317516666
##########
extensions/http-curl/client/HTTPClient.cpp:
##########
@@ -328,18 +325,15 @@ void HTTPClient::setRequestHeader(std::string key,
std::optional<std::string> va
}
namespace {
-struct CurlSListFreeAll {
- void operator()(struct curl_slist* slist) const {
- curl_slist_free_all(slist);
- }
-};
+using CurlSlistDeleter = decltype([](struct curl_slist* slist) {
curl_slist_free_all(slist); });
-std::unique_ptr<struct curl_slist, CurlSListFreeAll> getCurlSList(const
std::unordered_map<std::string, std::string>& request_headers) {
+std::unique_ptr<struct curl_slist, CurlSlistDeleter> toCurlSlist(const
std::unordered_map<std::string, std::string>& request_headers) {
curl_slist* new_list = nullptr;
+ const auto guard = gsl::finally([&new_list]() {
curl_slist_free_all(new_list); });
Review Comment:
I think this is too trivial to deduplicate, just like we don't extract and
deduplicate `free` calls in a typical C codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
