ChrisSamo632 commented on code in PR #7529:
URL: https://github.com/apache/nifi/pull/7529#discussion_r1317723279
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -371,9 +391,9 @@ protected PropertyDescriptor
getSupportedDynamicPropertyDescriptor(final String
private ValidationResult validateDynamicKCLConfigProperty(final String
subject, final String input, final ValidationContext context) {
final ValidationResult.Builder validationResult = new
ValidationResult.Builder().subject(subject).input(input);
- if (!subject.matches("^(?!with)[a-zA-Z]\\w*$")) {
+ if
(!subject.matches("^(?!with)[a-zA-Z][a-zA-Z0-9_]*(\\.[a-zA-Z][a-zA-Z0-9_]*)?$"))
{
Review Comment:
I guess that's a fair point, no object to the `(?!with)` prefix check
staying in the RegEx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
